Web3 · Smart Contract Audit

MKX Real Estate Security Audit

softstack completed a smart contract audit of MKX Real Estate's Fractional NFT Factory in July 2025, reporting 9 findings (1 critical, 2 high, 3 medium, 1 low and 2 informational), of which 9 were resolved or mitigated before the final report. The full report is published in the softstack public audit archive.

Key facts

Client
MKX Real Estate
Completed
Languages
Solidity
Commit
df0120cae8ad

About the project

MKX Real Estate is a digital property investment platform that offers fractional ownership of real estate in Dubai. The platform runs on blockchain infrastructure and tokenises shares in individual properties so that investors can take small positions. MKX presents itself as a regulated offering open to international investors.

Scope

Source repositorygithub.com/nitish011-01/MKX_FRACTINONAL_NFT

Components reviewed

1 module
  1. See the published report for the file list

Findings

1Critical
2High
3Medium
1Low
2Informational

9 of 9 findings resolved before the final report.

IDTitleSeverityStatus
6.2.1Admin Can Seize All User Funds

The contract grants the admin role the unilateral and unrestricted ability to withdraw the entire ETH and USDT balance held by the contract. This includes user capital deposited for share purchases and revenue awaiting distribution.

Criticalfixed
6.2.2Flawed Revenue Distribution Logic Causes Direct Financial Loss

The distributeRevenue() function contains two critical flaws in its financial calculations that directly harm shareholders: • Incorrect Denominator: Revenue is divided by property.totalShares (the maximum possible share count) instead of…

Highfixed
6.2.3Unenforced Transfer Restrictions Bypass All Security Policies

The contract intends to enforce transfer controls (e.g., pausable, transferability flag, expiry, blacklisting) via a _transferCheck() function.

Highfixed
6.2.4Unbounded Loops in Core Functions Will Lead to Permanent Denial of Service (DoS)

Multiple core functions, including distributeRevenue(), _updateShareholderData(), and _burnAndUpdateShares(), rely on for loops that iterate through an unbounded array of shareholders.

Mediumfixed
6.2.5Metadata Locking Mechanism is Non-Functional

The feature that allows users to lock property metadata is logically broken. The lockMetadata() function sets a lock using the NFT’s tokenId as the map key, but the setPropertyMetadata() function checks for this lock using the propertyId…

Mediumfixed
6.2.6Signatures Vulnerable to Cross-Contract Replay Attack

The signature scheme for purchasing shares does not include a unique domain separator (such as the contract’s address and the chain ID), which is a critical component of the EIP-712 standard.

Mediumfixed
6.2.7Incomplete Event Emission and Unused Code

Several functions that perform critical state changes, such as updateSharePrice(), setPropertyActive(), and withdrawRevenue(), do not emit events.

Lowfixed
6.2.8Unused Constants and Code

The contract defines constants TIMELOCK_DELAY and PERCENTAGE_BASE which are never used in any of the contract's logic. This adds unnecessary code, slightly increases deployment gas costs, and can be confusing for developers or auditors.

Informationalfixed
6.2.9Failing Tests in PropertyFractionalNFT.t.sol

The test suite for PropertyFractionalNFT currently fails on 5 individual tests, indicating possible inconsistencies between expected vs. actual contract behavior. These should be investigated and addressed to ensure contract robustness.

Informationalfixed

About this engagement

A smart contract audit reviews on-chain code for flaws an attacker could exploit. Engineers trace how assets move through the contracts, check who can call privileged functions, and test the arithmetic, external calls and upgrade paths. Each finding is rated by severity, and fixes are re-checked before the final report.

How softstack runs smart contract audits

Methodology

Review process

  1. Scoping and threat modelling

    The commit hash is frozen and the attack surface is mapped: asset flows, trust assumptions, privileged roles and the external systems the code depends on.

  2. Automated analysis

    Static analysers sweep the full codebase to surface known weakness patterns, unreachable states and deviations from established conventions.

  3. Manual code review

    Independent engineers read the code line by line, concentrating on business logic, access control, arithmetic and the handling of external calls.

  4. Adversarial testing

    Property-based fuzzing and invariant tests attack the assumptions the protocol relies on, targeting states that ordinary unit tests never reach.

  5. Reporting

    Every finding is documented with a severity rating, its impact, the steps to reproduce it and a concrete remediation the team can act on.

  6. Remediation verification

    Submitted fixes are re-reviewed against the original finding, and the final report records the resolved state of each one.

FAQ

MKX Real Estate was audited by softstack GmbH, a German Web3 security and software company based in Flensburg and certified to ISO/IEC 27001 by TÜV SÜD. softstack completed a smart contract audit for MKX Real Estate in July 2025. The full report is linked on this page and published in the softstack public audit archive.

The review reported 9 findings: 1 critical, 2 high, 3 medium, 1 low and 2 informational. 9 of 9 were resolved or mitigated before the final report.

The review covered the code in github.com/nitish011-01/MKX_FRACTINONAL_NFT at commit df0120c. The published report lists every file covered.

This report covers the code as reviewed in July 2025 at commit df0120c. Any code changed after that point is outside the reviewed scope.

Related audits

Browse all security audits

Disclaimer

This audit represents a point-in-time security assessment of the reviewed codebase and is intended for informational purposes only. While Softstack applies industry-standard security review methodologies, no audit can guarantee the absence of vulnerabilities, bugs, or other security risks. This report does not constitute financial, legal, regulatory, or investment advice, nor does it endorse the project, its business model, products, or services. Security is an ongoing process, and we strongly recommend conducting a new assessment following any material code changes or at least every 6 months to address newly emerging threats, vulnerabilities, and ecosystem developments.