Web3 · Smart Contract Audit

PDAX Security Audit

softstack completed a smart contract audit of PDAX's Mintoo NFT Framework in April 2023, reporting 7 findings (3 low and 4 informational), of which 6 were resolved or mitigated before the final report. The full report is published in the softstack public audit archive.

Key facts

Client
PDAX
Completed
Languages
Solidity, JavaScript
Commit
4e7c51f14864

About the project

PDAX is a cryptocurrency and digital asset exchange operated by Philippine Digital Asset Exchange, Inc. The platform is regulated by the Bangko Sentral ng Pilipinas and offers trading in cryptocurrencies, tokenised government bonds and digital collectibles. Cash-in and cash-out are handled through partner banks, e-wallets and over-the-counter agents.

Scope

Source repositorygithub.com/PixoPH/nft-smart-contracts

Components reviewed

4 modules · 4 files
  1. ERC1155Collection.sol
  2. ERC2981.sol
  3. truffle-config.js
  4. hardhat.config.js

Findings

0Critical
0High
0Medium
3Low
4Informational

6 of 7 findings resolved before the final report.

IDTitleSeverityStatus
6.2.1Missing Value Verification

The constructor lacks a value safety checks. Therefore, only values that are consistent with the logic of the contract should be permitted.

Lowfixed
6.2.2Misleading In-Line Comment

In the current implementation are some comments not matching to the implemented logic. This could lead to misleading understanding and usage of the code.

Lowfixed
6.2.3Gas Optimization

In the current implementation are some dynamic function parameters defined as memory where they could be calldata.

Lowfixed
6.2.4Unused Variable

The _tokenRoyaltyInfo variable is defined as a private state variable but its value is never initialized. The _defaultRoyaltyInfo is used for all tokens.

Informationalfixed
6.2.5Naming Convention

In the current implementation immutable variables are written in camel case where they should be written in upper case.

Informationalfixed
6.2.6Floating Pragma Versions Identified

It is recommended to specify a fixed compiler version to ensure that the bytecode produced does not vary between builds. This is especially important if you rely

Informationalfixed
6.2.7Storing data via contractURI

In the current implementation the contractURI is not hardcoded, means the owner/creator is free to choose the way how the metadata file is stored.

Informationalacknowledged

About this engagement

A smart contract audit reviews on-chain code for flaws an attacker could exploit. Engineers trace how assets move through the contracts, check who can call privileged functions, and test the arithmetic, external calls and upgrade paths. Each finding is rated by severity, and fixes are re-checked before the final report.

How softstack runs smart contract audits

Methodology

Review process

  1. Scoping and threat modelling

    The commit hash is frozen and the attack surface is mapped: asset flows, trust assumptions, privileged roles and the external systems the code depends on.

  2. Automated analysis

    Static analysers sweep the full codebase to surface known weakness patterns, unreachable states and deviations from established conventions.

  3. Manual code review

    Independent engineers read the code line by line, concentrating on business logic, access control, arithmetic and the handling of external calls.

  4. Adversarial testing

    Property-based fuzzing and invariant tests attack the assumptions the protocol relies on, targeting states that ordinary unit tests never reach.

  5. Reporting

    Every finding is documented with a severity rating, its impact, the steps to reproduce it and a concrete remediation the team can act on.

  6. Remediation verification

    Submitted fixes are re-reviewed against the original finding, and the final report records the resolved state of each one.

Standards and references

  • SWC RegistrySmart Contract Weakness Classification
  • CWECommon Weakness Enumeration

FAQ

PDAX was audited by softstack GmbH, a German Web3 security and software company based in Flensburg and certified to ISO/IEC 27001 by TÜV SÜD. softstack completed a smart contract audit for PDAX in April 2023. The full report is linked on this page and published in the softstack public audit archive.

The review reported 7 findings: 3 low and 4 informational. 6 of 7 were resolved or mitigated before the final report.

4 source files were reviewed in github.com/PixoPH/nft-smart-contracts at commit 4e7c51f. The published report lists every file covered.

This report covers the code as reviewed in April 2023 at commit 4e7c51f. Any code changed after that point is outside the reviewed scope.

Related audits

Browse all security audits

Disclaimer

This audit represents a point-in-time security assessment of the reviewed codebase and is intended for informational purposes only. While Softstack applies industry-standard security review methodologies, no audit can guarantee the absence of vulnerabilities, bugs, or other security risks. This report does not constitute financial, legal, regulatory, or investment advice, nor does it endorse the project, its business model, products, or services. Security is an ongoing process, and we strongly recommend conducting a new assessment following any material code changes or at least every 6 months to address newly emerging threats, vulnerabilities, and ecosystem developments.